-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prover commitment serialization #1031
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
I'd expect the bitcoin da verifier tests to fail? Do you know if bitcoin da parsers should also change? |
0485f25
to
9744817
Compare
75d4229
to
024f878
Compare
@eyusufatik This is specific to method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay as a tmp fix to make things work. However a proper fix needs to be implemented. Will do tomorrow.
Description
This pr fixes the DaData ser/de. BitcoinService serialized the inner values of DaData, while other components tried to deserialize it using
DaData::try_from_slice
.