Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DaServiceConfig to BitcoinServiceConfig #1029

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Rename DaServiceConfig to BitcoinServiceConfig #1029

merged 1 commit into from
Aug 21, 2024

Conversation

okkothejawa
Copy link
Contributor

Description

Renames DaServiceConfig to BitcoinServiceConfig.

Linked Issues

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (1bacc1e) to head (b20cb98).
Report is 1 commits behind head on nightly.

Files Patch % Lines
crates/bitcoin-da/src/service.rs 50.0% 3 Missing ⚠️
bin/citrea/src/main.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
bin/citrea/src/rollup/bitcoin.rs 0.0% <ø> (ø)
...vereign-sdk/full-node/sov-stf-runner/src/config.rs 92.8% <ø> (ø)
bin/citrea/src/main.rs 0.0% <0.0%> (ø)
crates/bitcoin-da/src/service.rs 43.6% <50.0%> (ø)

... and 2 files with indirect coverage changes

@eyusufatik eyusufatik merged commit a661777 into nightly Aug 21, 2024
12 checks passed
@eyusufatik eyusufatik deleted the okko/rename-da-service-config branch August 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik eyusufatik approved these changes

@kpp kpp kpp approved these changes

@ercecan ercecan Awaiting requested review from ercecan

@jfldde jfldde Awaiting requested review from jfldde

@rakanalh rakanalh Awaiting requested review from rakanalh

@yaziciahmet yaziciahmet Awaiting requested review from yaziciahmet

Assignees

@okkothejawa okkothejawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename DaServiceConfig to BitcoinServiceConfig
3 participants
@okkothejawa @kpp @eyusufatik