Make RPC handlers async #1019
Closed
Make RPC handlers async #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakanalh
commented
Aug 19, 2024
crates/sovereign-sdk/module-system/sov-modules-rollup-blueprint/src/runtime_rpc.rs
Outdated
Show resolved
Hide resolved
rakanalh
commented
Aug 19, 2024
crates/sovereign-sdk/module-system/sov-modules-macros/src/rpc/rpc_gen.rs
Outdated
Show resolved
Hide resolved
eyusufatik
reviewed
Aug 20, 2024
There was a problem hiding this comment.
way too macro business going on. leaving review of this to @kpp
one thing I want to understand is by making rpc functions async, we get to have tokio manage long running rpc calls better, am i right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues