Sign aggr tx list - bitcoin DA type 1 #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
jfldde,
rakanalh and
yaziciahmet
eyusufatik
approved these changes
Aug 16, 2024
kpp
added a commit
that referenced
this pull request
Aug 20, 2024
* Bitcoin DA versions * Fix parser tests, review comments * Init chunked txs * Chain chunked parts with utxos * Actually construct Type0/Type1 based on body size * fix script for type 0 * Fix scripts with checksigverify * Add vout index for prev tx (#961) * Add vout index for prev tx * replace prev_tx logic with prev_utxo logic * remove RawUTXO --------- Co-authored-by: eyusufatik <[email protected]> * Esad/better inclusion proof (#991) * depend only on wtxid * verify merkle root of coinbase tx, use zkvm efficient sh256 and bitcoin merkle tree * remove unused asserts * pr fixes * pr fixes * Add batchproof/lightclient namespaces. Add SequencerCommitment tx type * Apply #961 again * Esad get_service * Sign list of tx of aggregates tx instead of body (#1003) * fix bitcoin da test suite (#1009) * get ready for test fixes * fix tests * reactivate some of the verifier tests * fix remaning bitcoin-da tests * cleanup * clippy * Kpp/merkle tests (#1017) * Add merkle tree tests (#995) * Add merkle tree tests * Add 1 tx test to bitcoin compare --------- Co-authored-by: yaziciahmet <yaziciahmetcleargmail.com> * Fix errors/lints --------- Co-authored-by: Ahmet Yazıcı <[email protected]> * Allow dead code * Fix tx prefixes in guest-bitcoin * Review fixes * Review fix * Revert test non_parseable_tx * Rename parse_transaction -> parse_light_client_transaction * fix confusion on BitcoinService::new (#1025) --------- Co-authored-by: eyusufatik <[email protected]> Co-authored-by: Erce Can Bektüre <[email protected]> Co-authored-by: Esad Yusuf Atik <[email protected]> Co-authored-by: Ahmet Yazıcı <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we signed the body > 400kb of zkproof instead of list of txs.