ledger: Add add_transaction, which combines add_transaction_unconditi…

…onally and check_transaction.

src/client/rpc_api.rs

@@ -43,9 +43,7 @@ impl RpcApi for Client {
     ) -> bitcoincore_rpc::Result<bitcoin::Txid> {
         let tx: Transaction = encode::deserialize_hex(&tx.raw_hex()).unwrap();
 
-        self.ledger.check_transaction(tx.clone())?;
-
-        self.ledger.add_transaction_unconditionally(tx.clone())?;
+        self.ledger.add_transaction(tx.clone())?;
 
         Ok(tx.compute_txid())
     }

src/ledger/transactions.rs

@@ -14,6 +14,12 @@ impl Ledger {
         get_item!(self.utxos);
     }
 
+    /// Adds transaction to current block, after verifying.
+    pub fn add_transaction(&self, transaction: Transaction) -> Result<Txid, LedgerError> {
+        self.check_transaction(&transaction)?;
+
+        self.add_transaction_unconditionally(transaction)
+    }
     /// Adds transaction to current block, without checking anything.
     pub fn add_transaction_unconditionally(
         &self,
@@ -45,12 +51,12 @@ impl Ledger {
     /// # Panics
     ///
     /// If mutex can't be locked, it will panic.
-    pub fn check_transaction(&self, transaction: Transaction) -> Result<(), LedgerError> {
+    pub fn check_transaction(&self, transaction: &Transaction) -> Result<(), LedgerError> {
         Ok(self
             .database
             .lock()
             .unwrap()
-            .verify_transaction(&transaction)?)
+            .verify_transaction(transaction)?)
     }
 }