Fix fee output in get transaction rpc output #328
Conversation
…ther colorids in GetAmounts function. remove code from gettransaction RPC that was ineffective change all functional tests to look for 'fee' in the 'details' section of gettransaction rpc output
| @@ -0,0 +1,87 @@ | |||
| Tapyrus version 0.6.0 is now available for download at: | |||
There was a problem hiding this comment.
| Tapyrus version 0.6.0 is now available for download at: | |
| Tapyrus version 0.6.1 is now available for download at: |
| tapyrus testnet follow the instruction in [getting_started](doc/tapyrus/getting_started.md#how-to-start-a-node-on-tapyrus-testnet) to start a new Tapyrus v0.6.1 node. | ||
|
|
||
| If you are running a private tapyrus network using older versions of tapyrus-core release, shut it down. Wait until it has completely shut down. | ||
| Follow the instruction in [getting_started](doc/tapyrus/getting_started.md#how-to-start-a-new-tapyrus-network) to sart a new Tapyrus v0.6.0 network. Tapyrus blockchain created by older versions, before v0.5.0 |
There was a problem hiding this comment.
| Follow the instruction in [getting_started](doc/tapyrus/getting_started.md#how-to-start-a-new-tapyrus-network) to sart a new Tapyrus v0.6.0 network. Tapyrus blockchain created by older versions, before v0.5.0 | |
| Follow the instruction in [getting_started](doc/tapyrus/getting_started.md#how-to-start-a-new-tapyrus-network) to sart a new Tapyrus v0.6.1 network. Tapyrus blockchain created by older versions, before v0.5.0 |
| @@ -1705,9 +1705,6 @@ static UniValue gettransaction(const JSONRPCRequest& request) | |||
| "2. \"include_watchonly\" (bool, optional, default=false) Whether to include watch-only addresses in balance calculation and details[]\n" | |||
| "\nResult:\n" | |||
| "{\n" | |||
| " \"amount\" : x.xxx, (numeric) The transaction amount in " + CURRENCY_UNIT + "\n" | |||
| " \"fee\": x.xxx, (numeric) The amount of the fee in " + CURRENCY_UNIT + ". This is negative and only available for the \n" | |||
| " 'send' category of transactions.\n" | |||
There was a problem hiding this comment.
This was incorrect as it does not show all the tokens.
In this output the token, amount and fee are shown twice, once in the beginning and once in the details section
I removed the top one and kept the details. The RPc description was not updated correctly too, it is missing token key pair.
gettransaction dbe4537857ffcb0e30c6fae79a22721d3c123a30860d7488a795afdcc55e31d3
{
"token": "TPC",
"amount": 0.00000000,
"fee": -0.00000258,
"confirmations": 0,
"trusted": true,
"txid": "dbe4537857ffcb0e30c6fae79a22721d3c123a30860d7488a795afdcc55e31d3",
"walletconflicts": [
],
"time": 1735404354,
"timereceived": 1735404354,
"bip125-replaceable": "no",
"details": [
{
"address": "4ZqzwozvapgvKcj4i5P3BRtXTpHmpQmkiamKaVLE6iXFeVoxm3NvGUoaHcuweD92Euyo6V1mDYLgZXc",
"category": "receive",
"token": "c2764880024b95656b9e7929ad685ba9f207d8115d6e2cfef3b762910aa1132fc7",
"amount": 5000,
"vout": 0
}
]
add fee to receive address details if there was no send address from the wallet in the tx
gettransactionrpc showed zero fees in token issue/transafer transactions. This is fixed by separating the fee calculation code and the code calculating the credit and debit of other coloured coins.functional tests are updated to check the new location to get the fee.
token transactions were reporting incorrect fee or amount: