-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warnings for 0.6.0 release #321
Open
Naviabheeman
wants to merge
10
commits into
chaintope:master
Choose a base branch
from
Naviabheeman:FixWarningsForRelease
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix compiler warnings for 0.6.0 release #321
Naviabheeman
wants to merge
10
commits into
chaintope:master
from
Naviabheeman:FixWarningsForRelease
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naviabheeman
force-pushed
the
FixWarningsForRelease
branch
3 times, most recently
from
November 26, 2024 09:54
9af06f1
to
7b2be45
Compare
… it compatible with fs::filesystem remove IsDirWritable(like bitcoin) and update LocKDirectory to capture that status also. port LockResult for directory locking from bitcoin. update its tests remove unused variables across files
…rning move seed node list from federationparams to params and this list should be different for prod and test remove unused variables across files
fix wallet loading paths - make it relative to default wallet dir only if it is not an absolute path remove C_89 requirement from autogen.sh configure: make Qt compilation off by default change BadXFieldException to store the message and return its pointer to fix the warning. change memset usage in colored coin and other functions that gave warning
Naviabheeman
force-pushed
the
FixWarningsForRelease
branch
from
November 26, 2024 11:51
8b8471e
to
e6f64d7
Compare
… as it caused test failures
…de warnings and extreme delays in tapyrusd startup add execute permission to functional tests which didn't have them
Naviabheeman
force-pushed
the
FixWarningsForRelease
branch
from
December 3, 2024 10:11
5cc302c
to
36ebebb
Compare
azuchi
requested changes
Dec 4, 2024
Naviabheeman
force-pushed
the
FixWarningsForRelease
branch
3 times, most recently
from
December 5, 2024 12:48
b7d92fe
to
de3c571
Compare
…nd to member function. Fix its usages remove glibcxx sanity checks, glib sanity checks and glibc back compat code as it is not needed anymore.
Naviabheeman
force-pushed
the
FixWarningsForRelease
branch
from
December 5, 2024 13:57
de3c571
to
b6a785c
Compare
azuchi
reviewed
Dec 12, 2024
@@ -54,7 +54,7 @@ AC_DEFUN([BITCOIN_QT_INIT],[ | |||
dnl enable qt support | |||
AC_ARG_WITH([gui], | |||
[AS_HELP_STRING([--with-gui@<:@=no|qt5|auto@:>@], | |||
[build tapyrus_qt GUI (default=auto)])], | |||
[build tapyrus_qt GUI (default=no)])], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this?
@@ -1143,6 +1115,7 @@ else | |||
MINIUPNPC_CPPFLAGS="-DSTATICLIB -DMINIUPNP_STATICLIB" | |||
fi | |||
else | |||
use_upnp=no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes include: