Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings for 0.6.0 release #321

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Naviabheeman
Copy link
Contributor

Major changes include:

  • remove C_89 requirement from autogen.sh
  • configure: make Qt compilation off by default
  • move seed node list from federationparams to params and this list should be different for prod and test
  • fix boost::filesystem deprecated warnings in many functions and make it compatible with fs::filesystem change
  • port LockResult and LocKDirectory for directory locking result from bitcoin, remove IsDirWritable and update its tests
  • remove memset usage in colored coin and other functions that gave warning
  • change BadXFieldException to store the exception message and return a pointer to that string to fix a warning.
  • remove unused variables and functions across files

@Naviabheeman Naviabheeman force-pushed the FixWarningsForRelease branch 3 times, most recently from 9af06f1 to 7b2be45 Compare November 26, 2024 09:54
… it compatible with fs::filesystem

    remove IsDirWritable(like bitcoin) and update LocKDirectory to capture that status also.
    port LockResult for directory locking from bitcoin. update its tests
    remove unused variables across files
…rning

    move seed node list from federationparams to params and this list should be different for prod and test
    remove unused variables across files
    fix wallet loading paths - make it relative to default wallet dir only if it is not an absolute path
    remove C_89 requirement from autogen.sh
    configure: make Qt compilation off by default
    change BadXFieldException to store the message and return its pointer to fix the warning.
    change memset usage in  colored coin and other functions that gave warning
…de warnings and extreme delays in tapyrusd startup

add execute permission to functional tests which didn't have them
@Naviabheeman Naviabheeman force-pushed the FixWarningsForRelease branch from 5cc302c to 36ebebb Compare December 3, 2024 10:11
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@Naviabheeman Naviabheeman force-pushed the FixWarningsForRelease branch 3 times, most recently from b7d92fe to de3c571 Compare December 5, 2024 12:48
…nd to member function. Fix its usages

 remove glibcxx sanity checks, glib sanity checks and glibc back compat code as it is not needed anymore.
@Naviabheeman Naviabheeman force-pushed the FixWarningsForRelease branch from de3c571 to b6a785c Compare December 5, 2024 13:57
@@ -54,7 +54,7 @@ AC_DEFUN([BITCOIN_QT_INIT],[
dnl enable qt support
AC_ARG_WITH([gui],
[AS_HELP_STRING([--with-gui@<:@=no|qt5|auto@:>@],
[build tapyrus_qt GUI (default=auto)])],
[build tapyrus_qt GUI (default=no)])],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

@@ -1143,6 +1115,7 @@ else
MINIUPNPC_CPPFLAGS="-DSTATICLIB -DMINIUPNP_STATICLIB"
fi
else
use_upnp=no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants