Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor files #298

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Refactor files #298

wants to merge 26 commits into from

Conversation

Naviabheeman
Copy link
Contributor

@Naviabheeman Naviabheeman commented Mar 1, 2024 •
edited
Loading

This PR is only refactoring of validation.cpp file. There is no code modification, it is only code move. This PR does not change behaviour. No new tests are added.

New files:

  1. chainstate.h and chainstate.cpp
  • these two files now contain all the chain state class and global chain state, g_chainstate.
  1. cs_main.h and cs_main.cpp
  • This is similar to bitcoin. These files contains global mutex cs_main and cs_LastBlockFile. This makes accessing. these two critical sections from multiple files possible.
  1. file_io.h and file_io.cpp
  • All disk operations are moved to these new files
  1. scriptcheck.h
  • contains CScriptCheck class
  1. verifydb.h and verifydb.cpp
  • contains CVerifyDB class
  1. blockprune.h and blockprune.cpp
  • global functions that are related to block pruning are in these files

@Naviabheeman
refactor AcceptToMempool arguments:
e2c0a76 
remove mempool - it is a global
add all other flags in one struct
add all outputs in the same struct
@Naviabheeman
added Package test accept to mempool and submit package
0f29808
@Naviabheeman
Add packages rpcs testmempoolaccept and submit package to tapyrus core
5a8010a 
packages are vector of transactions just like bitcoin. coins from the package being validated are kept in CTxMempoolView like bitcoin
Because of the structure of our accept to mempool code, package validation can be achieved with much less code change.
@Naviabheeman
fix buid - remove conflict markers
8e237c1
@Naviabheeman
fix build - changed overwritted by rebase are corrected
b890086 
const CTxMempool is changed to non-const
@Naviabheeman
fix build - add code to add package transactions to temp list in coin…
3232f76 
… cache
@Naviabheeman
remove extra univalue in test package acceptance result
90592d0
@Naviabheeman
fix syntax of messing input error in der signature test
7a64d8f
@Naviabheeman
fix rpc help - add packages to rpc categories
b74cef7
@Naviabheeman
fix result of debug mode script - feature_cltv
f0562e4
@Naviabheeman
refactor AcceptToMempool arguments:
fd8114f 
remove mempool - it is a global
add all other flags in one struct
add all outputs in the same struct
@Naviabheeman
make smaller function calls from AcceptToMemoryPoolWorker to simplify it
d7b07ec
@Naviabheeman
make smaller function calls from AcceptToMemoryPoolWorker to simplify it
bdbd807
@Naviabheeman
fix test failure - use state and missing inputs from opt instead of s…
76b6cba 
…eperate flags
@Naviabheeman
review feedback - put back currentBlockScriptVerifyFlags
10153f8
@Naviabheeman
refactor AcceptToMempool arguments:
9df08cd 
remove mempool - it is a global
add all other flags in one struct
add all outputs in the same struct
@Naviabheeman
added Package test accept to mempool and submit package
966e431
@Naviabheeman
add colored coin tests for package accept to mempool
4316f2d
@Naviabheeman
fix package acceptance after refactoring.
59f1f7b 
change test result according to new output
@Naviabheeman
Fix mempool lock causing delay in package acceptance
75ba8a6 
add colored coin issue and spend in the same package
@Naviabheeman
add submit package tests
e9b6855 
refactor package rpcs to return well formed rpcs
fix otherf ailing test cases
@Naviabheeman
remove submit package test as it causes segmentation fault
c57de8d
@Naviabheeman
split validation.cpp into multiple files:
471d5e2 
    validation.cpp - only transaction and block validation code
    verifydb.cpp - veridydb class
    chainstate.cpp - chainstate class and other helper code used in it
    cs_main.cpp - common critical sections
    file_io.cpp - all disk read and write operations
    blockprune.cpp - blockprune class
@Naviabheeman Naviabheeman requested a review from azuchi June 12, 2024 12:57
azuchi
azuchi requested changes Jul 22, 2024
View reviewed changes
test/config copy.ini Outdated
ENABLE_WALLET=true
ENABLE_UTILS=true
ENABLE_BITCOIND=true
ENABLE_ZMQ=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file unecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azuchi azuchi azuchi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naviabheeman @azuchi