Port fixes from bitcoin #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark more assembly outputs as early clobber #1307 Use more volatile in temporarties #1303 save normalize_weak calls in secp256k1_gej_eq_x_var #1344 remove random_field_element_test and use random_fe_test instead upgrade CI to ubuntu22
fix compiler warnings in tests
azuchi
requested changes
Jul 12, 2024
azuchi
requested changes
Jul 12, 2024
src/tests.c
Outdated
| @@ -96,7 +96,7 @@ void random_group_element_test(secp256k1_ge *ge) { | |||
| void random_group_element_jacobian_test(secp256k1_gej *gej, const secp256k1_ge *ge) { | |||
| secp256k1_fe z2, z3; | |||
| do { | |||
| random_field_element_test(&gej->z); | |||
| random_fe_test(&gej->z); | |||
There was a problem hiding this comment.
In #1358, the following multiple lines are summarized:
do {
random_field_element_test(&gej->z);
if (!secp256k1_fe_is_zero(&gej->z)) {
break;
}
} while(1);There was a problem hiding this comment.
Yes, in our library I only removed the redundant random_field_element_test and used random_fe_test. Summarising the loop with random_fe_non_zero_test was not my initial intent as I wanted to make minimal change. I'll port it since it is causing confusion.
src/tests.c
Outdated
| @@ -1930,7 +1921,7 @@ void test_ge(void) { | |||
| if (i == 0) { | |||
| /* The point at infinity does not have a meaningful z inverse. Any should do. */ | |||
| do { | |||
| random_field_element_test(&zs[i]); | |||
| random_fe_test(&zs[i]); | |||
There was a problem hiding this comment.
In #1356, the while loop itself has also disappeared.
src/tests.c
Outdated
| @@ -1942,7 +1933,7 @@ void test_ge(void) { | |||
|
|
|||
| /* Generate random zf, and zfi2 = 1/zf^2, zfi3 = 1/zf^3 */ | |||
| do { | |||
| random_field_element_test(&zf); | |||
| random_fe_test(&zf); | |||
There was a problem hiding this comment.
In #1356, the while loop itself has also disappeared.
remove secp256k1_fe_normalize_weak from secp256k1_ge_is_valid_var port random_fe_non_zero_test and its usage
…fe_non_zero_test instead of loop
azuchi
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port:
Additionally: