Add version column to Timestamp table #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamaguchi
force-pushed
the
add_version_column_to_timestamp
branch
from
df5e216
to
f884b6f
Compare
|
Timestampモジュールの最上位あたりに、バージョニングの説明と各バージョンの挙動の差分が説明されたコメントが欲しいです。 |
rantan
reviewed
Jan 10, 2024
| @@ -14,6 +14,7 @@ class CreateTimestamp < ActiveRecord::Migration<%= migration_version %> | |||
| t.bigint :prev_id | |||
| t.boolean :latest, null: false, default: true | |||
| t.boolean :hex, null: false, default: false | |||
rantan
reviewed
Jan 10, 2024
| @@ -53,7 +56,8 @@ def initialize(attributes = nil) | |||
| status: :init, | |||
| timestamp_type: attributes[:timestamp_type] || :simple, | |||
| prev_id: attributes[:prev_id], | |||
| hex: hex | |||
| hex: hex, | |||
| version: attributes[:version] || "1" | |||
There was a problem hiding this comment.
Suggested change
| version: attributes[:version] || "1" | |
| version: attributes[:version] || "2" |
はどうでしょう？
Yamaguchi
force-pushed
the
add_version_column_to_timestamp
branch
3 times, most recently
from
98d6739
to
d62180c
Compare
|
Yamaguchi
force-pushed
the
add_version_column_to_timestamp
branch
from
d62180c
to
67c0415
Compare
azuchi
reviewed
Jan 12, 2024
azuchi
approved these changes
Jan 12, 2024
rantan
requested changes
Jan 12, 2024
| # - version [String] Version of the timestamp recording method. | ||
| # The format in which the timestamp is recorded differs depending on the version. | ||
| # Version "1" treats the specified content and prefix as a binary string. | ||
| # Version "2" treats the specified content and prefix as a hexadecimal string with the string set to prefix and content. |
There was a problem hiding this comment.
version が 1, 2 以外の場合は ArgumentError にした方が良いと思います。
rantan
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.