Implement Glueby::Wallet#tokens #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamaguchi
force-pushed
the
feature/token_api
branch
from
d6f1ac5
to
7b2e6f7
Compare
Yamaguchi
force-pushed
the
feature/token_api
branch
from
7b2e6f7
to
59aafc8
Compare
rantan
requested changes
Nov 9, 2023
Yamaguchi
force-pushed
the
feature/token_api
branch
from
c74ce82
to
e63b484
Compare
Yamaguchi
force-pushed
the
feature/token_api
branch
from
1daf6e2
to
b5d8641
Compare
Yamaguchi
force-pushed
the
feature/token_api
branch
from
98fd968
to
74b74f4
Compare
rantan
requested changes
Nov 28, 2023
rantan
requested changes
Dec 1, 2023
|
|
||
| before do | ||
| allow(internal_wallet).to receive(:list_unspent).with(color_id, true) | ||
| .and_return(unspents.select { |utxo| utxo[:color_id] == 'c150ad685ec8638543b2356cb1071cf834fb1c84f5fa3a71699c3ed7167dfcdbb3' }) |
There was a problem hiding this comment.
メモ
このテストでは、もともと list_unspent はスタブしていたが、今回のへ変更で list_unspent に color_id を指定することで、特定のcolor id の utxo だけを返すようにできるので、それを使用する想定でスタブの記述を上書きしたという事ですね。
少し理解に時間がかかったので他のレビュアーのためにメモとして残します。
| @@ -261,7 +266,7 @@ def fill_uncolored_inputs( | |||
| while current_amount - fee < target_amount | |||
| sum, utxos = collect_uncolored_outputs( | |||
| fee + target_amount - current_amount, | |||
| nil, nil, true, true, | |||
| nil, false, true, true, | |||
There was a problem hiding this comment.
only_finalized が nil になってたんですね、、nil でも false でも挙動は変わりませんが、boolean を想定している引数だと思うので、nil は変ですね。
rantan
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Glueby::Wallet#tokens to get token out_point(txid, index) and value.