Implement new REST API: GET /colors/ #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamaguchi
force-pushed
the
feature/get_colors_api
branch
from
78967d0 to
ef4a407
Compare
Yamaguchi
commented
Mar 15, 2024
| @@ -36,8 +36,8 @@ page_size = "0.4.2" | |||
| prometheus = "0.11.0" | |||
| openassets-tapyrus = "^0.2.4" | |||
| rayon = "1.5.0" | |||
| rocksdb = { version = "0.15.0", optional = true } | |||
| rocksdb-oldcpu = { version = "0.12.4", optional = true, package = "rocksdb" } | |||
| rocksdb = { version = "^0.22.0", optional = true } | |||
There was a problem hiding this comment.
最新のmacOS環境でビルドが通らなかったため、アップデート
Yamaguchi
commented
Mar 15, 2024
| @@ -26,7 +26,7 @@ impl<'a> Iterator for ScanIterator<'a> { | |||
| if self.done { | |||
| return None; | |||
| } | |||
| let (key, value) = self.iter.next()?; | |||
| let (key, value) = self.iter.next()?.ok()?; | |||
There was a problem hiding this comment.
最新のmacOS環境(rust: 1.76.0)でビルドが通らなかったため、修正
|
ちなみに、この実装だとすでに運用中のesplora-tapyrusがある場合は、データを削除してインデックスを作り直す必要があります。テストネットの場合だとインデックスの再作成に、現状20分以上は必要です。 |
azuchi
reviewed
Mar 15, 2024
…in descending order of block_height use
Yamaguchi
force-pushed
the
feature/get_colors_api
branch
2 times, most recently
from
48864d2 to
35f122f
Compare
Yamaguchi
force-pushed
the
feature/get_colors_api
branch
from
35f122f to
4f17079
Compare
azuchi
requested changes
Mar 29, 2024
doc/API.md
Outdated
| @@ -227,6 +227,13 @@ For example: `{ "1": 87.882, "2": 87.882, "3": 87.882, "4": 87.882, "5": 81.129, | |||
|
|
|||
| ## Tokens | |||
|
|
|||
| ### `GET /colors[/:last_seen_color_id]` | |||
|
|
|||
| Returns a list of the 25 (`color_id`, `block_height`) pairs | |||
There was a problem hiding this comment.
他に、chain_statsとmempool_statsも含まれているようなので、それぞれ何を指すか説明を追記してください。
rantan
approved these changes
Apr 2, 2024
azuchi
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new REST API
GET /colors/[:last_seen_color_id]
chaintope/tapyrus-explorer#55