Correct flaky test for parseUses
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a flaky test for the `parseUses` function which could fail if the randomly generated `ref` value contained an at sign. This would result in a constructed `uses:` value with multiple at signs, which is not valid (and would thus error unexpectedly). This is a followup to 8588dff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #40
Summary
Fix a flaky test for the
parseUsesfunction which could fail if the randomly generatedrefvalue contained an at sign. This would result in a constructeduses:value with multiple at signs, which is not valid (and would thus error unexpectedly).