Skip to content

Commit

Permalink
Initial commit
Browse files Browse the repository at this point in the history
  • Loading branch information
ericcornelissen committed Dec 30, 2023
0 parents commit 35dd46a
Show file tree
Hide file tree
Showing 9 changed files with 784 additions and 0 deletions.
22 changes: 22 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Check out EditorConfig at: https://editorconfig.org

root=true

[*]
charset=utf-8
insert_final_newline=true
max_line_length=100
trim_trailing_whitespace=true

[*.go]
indent_size=2
indent_style=tab

[*.md]
indent_size=unset
indent_style=space

[LICENSE]
indent_size=unset
indent_style=space
max_line_length=80
4 changes: 4 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
* text=auto

# don't diff machine generated files
go.sum -diff
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
gha.sum

## IDEs
.idea/
.vscode/
201 changes: 201 additions & 0 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
42 changes: 42 additions & 0 deletions NOTES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# SHAttered git commits

## Overview

1. The [SHAttered website](https://shattered.io/) states it's possible to make malicious git commits with the same SHA as an existing commit.
2. However, "the attack required 'the equivalent processing power of 6,500 years of single-CPU computations {...}.'" So it's not all that feasible in practice
3. From [SHA1 on Wikipedia](https://en.wikipedia.org/wiki/SHA-1), a more recent attack requires approximately the same amount of computation "{...} at the time of publication would cost US$45K per generated collision.

## Attack Description (in detail)

### Steps

1. Create valid commit and advertise it as a release (e.g. with a git tag or GitHub release).
2. Get people to use it.
3. Craft a malicious commit with the same hash.
4. People using that release now use malicious code which they can't tell from the integrity hash.

### Discussion

- I don't think that the older the release is (in terms of descendant commits) the harder this attack becomes. Namely, the child of a commit's only "chaining" to the parent is the parent's commit hash. So, since the commit hash didn't change there's no need to find a collision for more than one commit. The implication is that this attack can be carried out for any historical commit.
- Open questions:
- Can existing clones be used to detect this attack? What is git's behavior locally when the hash of a historic commit is unchanged but the contents did change?
- Can forks be used to detect this attack?

### Impact

- GitHub Actions
- Dependencies in GitHub Actions may be specified/identified/versioned by the commit SHA of the git repository that hosts the dependency (referred to as an "Action"). This is the most secure approach, alternatively it can be specified/identified/versioned using git refs (such as branches or tags) but those are inherently mutable.
- Hence, as a result of the attack GitHub Actions users that use external Actions have no guarantee the code that ran yesterday is the code that ran today.
- The only available protection is to limit what Actions that are allowed to be used in a project to Actions with a good security hygiene.
- Go mod
- Reference: <https://go.dev/ref/mod#authenticating>
- Dependencies in Go can (default, but alternatives exist) be pulled directly from a git repository. While you may reference the version you want to use by the commit hash, the Go module system will actually compute a SHA256 hash over the source and use that in the `go.sum` file instead. It is this hash that's used for integrity purposes
- Thus, even if a malicious commit is created for an existing commit hash, the Go module system would detect this through the SHA256 hash of the source code.
- Deno
- Dependencies in Deno can (^alternatives exist) be pulled directly from a git repository. As far as I can tell it doesn't rely on the commit hash for integrity ([ref](https://docs.deno.com/runtime/manual/basics/modules/integrity_checking)) and it seems to be using SHA256 ([ref](https://github.com/denoland/deno_lockfile/blob/75e3b2800e3fd6f3d62478a6cf15fd030d91a363/src/lib.rs#L29)), though I'm unsure what it hashes.

## Outcome

- Deno and Go are unaffected. Only the GitHub Actions ecosystem is affected.
- Build a system for GitHub Actions that stores and compares better hashes of the Actions source code (i.e. repository). Hashes could be stored in the repository and checked as a first step of any job.
- <https://github.com/ericcornelissen/ghasum>
27 changes: 27 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# `ghasum`

Checksums for GitHub Actions.

## Motivation

The dependency ecosystem for GitHub Actions is fully reliant on git. Dependencies can be specified
by a git ref (branch or tag) or commit SHA. Git refs provide no integrity guarantees. Commit SHAs do
provide integrity guarantees, but since they're based on SHA1 these guarantees are weaker then
necessary (see for example the [SHAttered] attack).

Hence, this project aims to provide a way to get, record, and validate checksums for GitHub Actions
dependencies using a more modern cryptographic hashing algorithm.

## TODO

An incomplete list of things that should be done:

- [ ] Better user experience
- [ ] Improve source code and use automated testing
- [ ] At least a basic continuous integration setup
- [ ] Record some sort of version in the checksum file in order to aid in changing the format or
changing the hash algorithm in the future
- [ ] Convenient support to run as a GitHub Action to validate dependency integrity before the (rest
of the) job runs

[shattered]: https://shattered.io/
31 changes: 31 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
module github.com/ericcornelissen/ghasum

go 1.21.0

require github.com/go-git/go-git/v5 v5.9.0

require (
dario.cat/mergo v1.0.0 // indirect
github.com/Microsoft/go-winio v0.6.1 // indirect
github.com/ProtonMail/go-crypto v0.0.0-20230828082145-3c4c8a2d2371 // indirect
github.com/acomagu/bufpipe v1.0.4 // indirect
github.com/cloudflare/circl v1.3.3 // indirect
github.com/cyphar/filepath-securejoin v0.2.4 // indirect
github.com/emirpasic/gods v1.18.1 // indirect
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
github.com/go-git/go-billy/v5 v5.5.0 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
github.com/kevinburke/ssh_config v1.2.0 // indirect
github.com/pjbgf/sha1cd v0.3.0 // indirect
github.com/sergi/go-diff v1.1.0 // indirect
github.com/skeema/knownhosts v1.2.0 // indirect
github.com/xanzy/ssh-agent v0.3.3 // indirect
golang.org/x/crypto v0.13.0 // indirect
golang.org/x/mod v0.12.0
golang.org/x/net v0.15.0 // indirect
golang.org/x/sys v0.12.0 // indirect
golang.org/x/tools v0.13.0 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v3 v3.0.1
)
Loading

0 comments on commit 35dd46a

Please sign in to comment.