Fix 'none' severity findings breaking tests #586
Merged
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
force-pushed
the
fix-none-findings
branch
from
5b30547
to
88d615e
Compare
egibs
changed the title
Signed-off-by: egibs <[email protected]>
egibs
force-pushed
the
fix-none-findings
branch
from
88d615e
to
d7f9b6c
Compare
tstromberg
requested changes
Nov 5, 2024
pkg/report/report.go
Outdated
| @@ -98,6 +98,8 @@ var dateRe = regexp.MustCompile(`[a-z]{3}\d{1,2}`) | |||
| // Map to handle RiskLevel -> RiskScore conversions. | |||
| var Levels = map[string]int{ | |||
| "harmless": 0, | |||
| "ignore": 0, | |||
There was a problem hiding this comment.
I'd like to make sure that the API boundary is clear without any unanticipated surprises. The fact that the API returns dropped results would be a surprise to me.
What do you think about assigning the levels to be dropped by default (at least ignore and none) as -1? I'm iffy on harmless, it's probably OK as is.
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
tstromberg
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #585
Our tests were not applying a consistent level of minimum risk. To avoid showing behaviors with
nonefor their severity, this PR setsMinFileRiskandMinRiskto1for all tests. For reference,TestJSONwas already usingMinRisk: 1.