feat(sidecar): keystore secrets path in config #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
force-pushed
the
lore/feat/keystore-secrets
branch
from
abea1cc
to
e804caf
Compare
thedevbirb
force-pushed
the
lore/feat/keystore-secrets
branch
from
19adcdc
to
eeab58e
Compare
thedevbirb
force-pushed
the
lore/feat/keystore-secrets
branch
from
0f31b6d
to
b390910
Compare
feat(sidecar): add commitment signing key + holesky deployment scripts
merklefruit
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291.
Closes #300.
Also it removes support for the default
keysdirectory for storing keystores -- it can introduce edge case for little upsides.To be merged together with chainbound/ethereum-package#20.
Re-tested e2e on devnet and it works on my machine™️