Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated devnet #285

Merged
merged 66 commits into from
Oct 14, 2024
Merged

fix: updated devnet #285

merged 66 commits into from
Oct 14, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Oct 8, 2024

Assorted fixes for the devnet before Holesky.

Constraints API

Sidecar

  • streamlined BlsPublicKey types to use less versions of the type (we have 4 different crates exporting it)
  • sign constraints inserting the signer pubkey instead of the target slot's validator pubkey, to unblock testing. This will require more attention when we want to make sure to sign with a key that is either authorized via delegation or is the validator private key itself
  • added tests w.r.t. constraints encoding, decoding & sig verify
  • applied changes to the constraints api for delegation and revocation messages

Builder

  • fix: decode constraints as single message instead of lists when unmarshaling them from SSE
  • fix: runtime error in commitTransaction implementation
  • fix: missing BlobsBundle in deneb submit block request MarshalJSON implementation
  • added tests w.r.t. constraints unmarshaling
  • re-added checks to verify that constraints are submitted by authorized keys

Bolt Boost

  • fix: calculate proof data correctly for type 3 blob txs
  • applied changes to the constraints api for delegation and revocation messages

Mev Boost

  • applied changes to the constraints api for delegation and revocation messages

Meta

@merklefruit merklefruit self-assigned this Oct 8, 2024
@merklefruit merklefruit added A: devnet Area: devnet T: bug Type: Bug labels Oct 8, 2024
@merklefruit merklefruit added this to the v0.3: Holesky 1 milestone Oct 8, 2024
@merklefruit merklefruit marked this pull request as ready for review October 9, 2024 16:30
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to rebase this PR but didn't work, I still see commits from #276. Can you try to update it?

Nvm, I thought #276 was merged into unstable.

bolt-boost/src/types.rs Outdated Show resolved Hide resolved
bolt-boost/src/types.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

daje

@thedevbirb thedevbirb merged commit 4634ff9 into unstable Oct 14, 2024
5 checks passed
@thedevbirb thedevbirb deleted the nico/devnet-fix branch October 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: devnet Area: devnet T: bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert disabling authorized pubkeys once testing is done on devnet
3 participants