Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci workflow + LICENSE #20

Merged
merged 17 commits into from
May 17, 2024
Merged

Add ci workflow + LICENSE #20

merged 17 commits into from
May 17, 2024

Conversation

knikos
Copy link
Member

@knikos knikos commented Apr 23, 2024

This PR consists of:

  • CI workflow
  • linter
  • LICENSE.yml.
  • basic unit testing coverage of core logic

Due to the introduction of linter, a lot of changes had to be made mostly due to copylocks warning from govet. This copylocks warning stems from the fact that pb generated go files include impl.MessageState which embeds amongother the DoNotCopy. This has lead to a massive restructuring

@knikos knikos requested a review from mo-c4t April 23, 2024 11:30
@knikos knikos force-pushed the nikos/workflows-license branch 5 times, most recently from cbcb30e to 0ade5cf Compare April 26, 2024 09:26
@knikos knikos requested a review from evlekht April 29, 2024 07:38
mo-c4t
mo-c4t previously approved these changes May 16, 2024
Copy link
Member

@mo-c4t mo-c4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/config.go Show resolved Hide resolved
@knikos knikos merged commit a22d8ee into c4t May 17, 2024
3 checks passed
@knikos knikos deleted the nikos/workflows-license branch May 17, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants