Export functions individually #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables one to do:
```js
import { getMessage } from 'check-error';
```
Previous code required:
```js
import checkError from 'check-error';
const { getMessage } = checkError;
```
keithamus
approved these changes
Jul 21, 2023
|
@koddsson would you like to land this one? |
|
Do btw note that this would be a breaking change, requiring to be released as eg 3.0.0 |
|
We could always keep both and not break 😃 |
koddsson
reviewed
Jul 22, 2023
| @@ -121,5 +121,3 @@ function getMessage(errorLike) { | |||
|
|
|||
| return msg; | |||
| } | |||
|
|
|||
| export { compatibleInstance, compatibleConstructor, compatibleMessage, getMessage, getConstructorName }; | |||
There was a problem hiding this comment.
Yeah, what do you think about keeping this, and we can release this as 3.0.1?
|
Never mind this PR, one shouldn't do PR:s at late Friday evenings evidently. I mixed up So: My PR is functionally identical to the existing code and as such a simple case of code formatting preference and as such a rather needless one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables one to do:
Previous code required: