Feature/add land register #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenning
reviewed
Jan 4, 2024
src/main/java/ch/ejpd/lgs/searchindex/client/entity/LandRegister.java
Outdated
Show resolved
Hide resolved
nenning
reviewed
Jan 4, 2024
src/main/java/ch/ejpd/lgs/searchindex/client/service/processor/PersonDataProcessor.java
Outdated
Show resolved
Hide resolved
nenning
reviewed
Jan 4, 2024
src/main/java/ch/ejpd/lgs/searchindex/client/service/sync/AbstractSyncService.java
Outdated
Show resolved
Hide resolved
nenning
reviewed
Jan 4, 2024
...st/java/ch/ejpd/lgs/searchindex/client/service/sync/FullSyncStateManagerMultiSenderTest.java
Show resolved
Hide resolved
markusborer
reviewed
Jan 4, 2024
src/main/java/ch/ejpd/lgs/searchindex/client/service/processor/PersonDataProcessor.java
Outdated
Show resolved
Hide resolved
markusborer
reviewed
Jan 4, 2024
nenning
reviewed
Jan 5, 2024
src/main/java/ch/ejpd/lgs/searchindex/client/service/sync/FullSyncStateManager.java
Show resolved
Hide resolved
nenning
reviewed
Jan 5, 2024
src/main/java/ch/ejpd/lgs/searchindex/client/configuration/SedexConfiguration.java
Outdated
Show resolved
Hide resolved
nenning
reviewed
Jan 5, 2024
kiril-atanasoff
commented
Feb 8, 2024
| if (!senderId.matches(SENDER_ID_REGEX)) { | ||
| throw new ResponseStatusException( | ||
| HttpStatus.BAD_REQUEST, | ||
| "Invalid X-LGS-Sender-Id header. Valid characters: A-Z, a-z, -, _"); |
There was a problem hiding this comment.
Doesn't tell the user what went wrong.
To point the user to change the header sent to the application
Add the user value
kiril-atanasoff
commented
Feb 8, 2024
|
|
||
| throw new SenderIdValidationException( | ||
| String.format( | ||
| "Validation of senderId failed, given senderId %s, valid senderId(s): %s.", |
There was a problem hiding this comment.
Sender id (customer values) is not found in the configuration. The given sender are the lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://isc-lgs.atlassian.net/browse/LGS-551
It also read the version property from the maven properties