custom marker #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've opened up the api to allow the user to specify a custom map_pin. When using other svg paths, you'll need to manually specify all the other marker element options correctly to make the pin display correctly. New options include: `viewBox`, `extraDivClasses`, `extraIconClasses`. `extraClasses` is no longer supported. `extraDivClasses` gets applied to the `div` wrapper for the marker. `extraIconClasses` acts as `extraClasses` did before. Example Options: ``` options.map_pin = 'M24 0c-9.8 0-17.7 7.8-17.7 17.4 0 15.5 17.7 30.6 17.7 30.6s17.7-15.4 17.7-30.6c0-9.6-7.9-17.4-17.7-17.4z'; opitons.iconSize = [36, 36]; opitons.iconAnchor = [18, 36]; opitons.popupAnchor = [0, -34]; opitons.viewBox = '0 0 48 48'; opitons.shadowSize = [36, 16]; opitons.shadowAnchor = [11, 9]; ``` I've also merged some of the changes from hiasinho#8 The icon tag was improperly put inside of the svg. Chrome seemed to pop this out by default, while other browsers (FF) didn't. BREAKING CHANGES: `extraClasses` is not longer supported.
Custom Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.