Skip to content

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
  • Loading branch information
cfsimplicity committed Mar 25, 2022
2 parents 339ba33 + 469c9c0 commit d86bb3f
Show file tree
Hide file tree
Showing 13 changed files with 32 additions and 17 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 3.4.4 - 25 March 2022

- \#289 Prevent one-off OSGi bundle errors when the bundle version changes
- \#290 Upgrade POI to 5.2.2

## 3.4.3 - 8 March 2022

- \#288 sheetInfo() should default to the currently active sheet, not the first
Expand Down
2 changes: 1 addition & 1 deletion ModuleConfig.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ component{
this.author = "Julian Halliwell";
this.webURL = "https://github.com/cfsimplicity/spreadsheet-cfml";
this.description = "CFML Spreadsheet Library";
this.version = "3.4.3";
this.version = "3.4.4";
this.autoMapModels = false;

function configure(){
Expand Down
4 changes: 2 additions & 2 deletions Spreadsheet.cfc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
component accessors="true"{

//"static"
property name="version" default="3.4.3" setter="false";
property name="osgiLibBundleVersion" default="5.2.1.0" setter="false"; //first 3 octets = POI version; increment 4th with other jar updates
property name="version" default="3.4.4" setter="false";
property name="osgiLibBundleVersion" default="5.2.2.0" setter="false"; //first 3 octets = POI version; increment 4th with other jar updates
property name="osgiLibBundleSymbolicName" default="spreadsheet-cfml" setter="false";
property name="exceptionType" default="cfsimplicity.spreadsheet" setter="false";
//commonly invoked POI class names
Expand Down
4 changes: 2 additions & 2 deletions box.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name" : "Spreadsheet CFML",
"slug" : "spreadsheet-cfml",
"version" : "3.4.3",
"version" : "3.4.4",
"shortDescription" : "CFML spreadsheet library",
"author" : "Julian Halliwell",
"location" : "https://github.com/cfsimplicity/spreadsheet-cfml/archive/v3.4.3.zip",
"location" : "https://github.com/cfsimplicity/spreadsheet-cfml/archive/v3.4.4.zip",
"homepage" : "https://github.com/cfsimplicity/spreadsheet-cfml",
"projectURL" : "https://github.com/cfsimplicity/spreadsheet-cfml",
"documentation" : "https://github.com/cfsimplicity/spreadsheet-cfml/blob/main/README.md",
Expand Down
10 changes: 5 additions & 5 deletions build/lib-osgi.mf
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Spreadsheet CFML
Bundle-SymbolicName: spreadsheet-cfml
Bundle-Version: 5.2.1.0
Bundle-Version: 5.2.2.0
Bundle-ClassPath: commons-codec-1.15.jar,
commons-collections4-4.4.jar,
commons-compress-1.21.jar,
commons-csv-1.9.0.jar,
commons-io-2.11.0.jar,
commons-math3-3.6.1.jar,
log4j-api-2.17.1.jar,
poi-5.2.1.jar,
poi-ooxml-5.2.1.jar,
poi-ooxml-full-5.2.1.jar,
log4j-api-2.17.2.jar,
poi-5.2.2.jar,
poi-ooxml-5.2.2.jar,
poi-ooxml-full-5.2.2.jar,
SparseBitSet-1.2.jar,
spreadsheet-cfml.jar,
xmlbeans-5.0.3.jar
2 changes: 1 addition & 1 deletion build/task.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ component{
variables.libPath = variables.rootPath & "lib/";
variables.classpathDirectories = [
variables.srcPath
,variables.libPath & "poi-ooxml-5.2.1.jar"
,variables.libPath & "poi-ooxml-5.2.2.jar"
,variables.libPath & "xmlbeans-5.0.3.jar"
];
var jarFileName = "spreadsheet-cfml.jar";
Expand Down
22 changes: 16 additions & 6 deletions helpers/class.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,22 @@ component extends="base" accessors="true"{

private any function loadClassUsingOsgi( required string javaclass ){
library().setJavaClassesLastLoadedVia( "OSGi bundle" );
return library().getOsgiLoader().loadClass(
className: arguments.javaclass
,bundlePath: this.getRootPath() & "lib-osgi.jar"
,bundleSymbolicName: library().getOsgiLibBundleSymbolicName()
,bundleVersion: library().getOsgiLibBundleVersion()
);
try{
return library().getOsgiLoader().loadClass(
className: arguments.javaclass
,bundlePath: this.getRootPath() & "lib-osgi.jar"
,bundleSymbolicName: library().getOsgiLibBundleSymbolicName()
,bundleVersion: library().getOsgiLibBundleVersion()
);
}
catch( org.osgi.framework.BundleException exception ){
if( exception.message.FindNoCase( "is not available in version" ) ){
library().flushOsgiBundle();
retry;
}
else
rethrow;
}
}

}
Binary file modified lib-osgi.jar
Binary file not shown.
Binary file not shown.
Binary file renamed lib/poi-5.2.1.jar → lib/poi-5.2.2.jar
Binary file not shown.
Binary file renamed lib/poi-ooxml-5.2.1.jar → lib/poi-ooxml-5.2.2.jar
Binary file not shown.
Binary file not shown.
Binary file modified lib/spreadsheet-cfml.jar
Binary file not shown.

0 comments on commit d86bb3f

Please sign in to comment.