Remove option for accordion behavior from expandables documentation

[marteki]

As shared in cfpb/capital-framework#536 and cfpb/capital-framework#665, we’ve removed the accordion option from our design patterns. This updates our documentation to match the implementation guidelines.

Removals

• Remove the description of the (buggy, not used) accordion behavior for expandables

Review

• @ielerol
• @anselmbradford
• @Scotchester

Screenshots

Documentation before changes

Documentation after changes

Checklist

• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows the standards laid out in the front end playbook
• Passes all existing automated tests
• New functions include new tests
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged
• Visually tested in supported browsers and devices
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

[marteki]

Whew! The build passed in Travis now. Needed to shift one of the dependencies and point it at a different location. Thanks to @Scotchester for his help on troubleshooting that.

[Scotchester]

This should replace grunt-contrib-uglify in the devDependencies list, and uglify-es can also be removed now.

[Scotchester]

This is totally fine now, but just to ask the question: Should we remove the Interactions section entirely, now? It seems a bit superfluous without the Accordion content.

[marteki]

@Scotchester Hmm. Maybe, if it's merged with the State section. I feel odd about having such an extensive Style section without explicitly calling out the Interactions, since it's an interactive web element.

Alright, I'll add that piece as a TODO to the list on our internal design patterns tracking page, and merging this.

[sebworks]

Hmmm, we are using the accordion on the OAH pages ( closing-disclosure / loan-estimate ) and I'm not in favor of removing them. The accordion allows you manage long content on mobile, without forcing the user to scroll or close other expandables.

[marteki]

@sebworks There's been a good bit of discussion about this already over the last several months, where designers and developers came to an understanding about the removal of the accordions. For more details and to catch up, see the summary at https://[GHE]/CFPB/hubcap/wiki/Design-pattern-additions-and-changes#expandable-accordions-removed.

The current plan was to adjust the expandable groups for the one known place where accordions are being used, but the Loan Estimate page was not previously called out as a place! Let's discuss it more internally.

(Somewhat related, and an issue you were previously tagged on for comment that might have gotten buried in your inbox: cfpb/capital-framework#536)

[ielerol]

Looks good to me!

[marteki]

Merging this, especially since the Travis work is needed for any other PRs to be merged successfully and #594 is waiting on it.