Update the wagtailcharts package and remove an outdated script #8700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wagtailcharts 0.6.2 release notes say 0.6.1 was not released correctly: https://github.com/overcastsoftware/wagtailcharts/releases In addition, it appears we copied in an old list of js dependencies that included a removed script, accounting.js: https://github.com/overcastsoftware/wagtailcharts/blob/main/RELEASE_NOTES.md?plain=1#L12 This updates the package to 0.6.2 and removes our include of accounting.js
csebianlander
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wagtailcharts 0.6.2 release notes say 0.6.1 was not released correctly: https://github.com/overcastsoftware/wagtailcharts/releases
In addition, it appears we copied in an old list of js dependencies that included accounting.js, a script removed in 0.6.
This updates the package to 0.6.2 and removes our include of accounting.js, which is causing server errors in production.