Analytics: Change load event to fire from the window instead of created script element #8015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this analytics code that fires a
gtmloaded
event when a script tag has loaded. The cfpb-analytics package looks for this event (see https://github.com/cfpb/cfpb-analytics/blob/main/packages/cfpb-analytics/src/cfpb-analytics.js#L109).If the gtm script loads before other scripts that use cfpb-analytics, it'll fire the
gtmloaded
event before other scripts. This PR changes this so that the load event fires on thewindow
, so that it'll fire after all page scripts have loaded.Changes
load
event listening from gtm script tag to window object.How to test this PR