Move disclosures to fetch-logic #8008
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| /** | ||
|
Check warning on line 1 in cfgov/unprocessed/apps/paying-for-college/js/disclosures/utils/dollar-sign.js
|
||
| * | ||
| * @param selector | ||
|
Check warning on line 3 in cfgov/unprocessed/apps/paying-for-college/js/disclosures/utils/dollar-sign.js
|
||
| */ | ||
| function Query(selector) { | ||
| this.elements = []; | ||
|
|
@@ -17,17 +17,11 @@ | |
| if (typeof selector === 'string' && selector !== '') { | ||
| this.elements = document.querySelectorAll(selector); | ||
| } | ||
| } | ||
|
|
||
| Query.prototype.attr = function (name, value) { | ||
| if (typeof value === 'undefined') { | ||
| return this.elements.length ? this.elements[0].getAttribute(name) : null; | ||
| } else { | ||
| this.elements.forEach((elem) => { | ||
| elem.setAttribute(name, value); | ||
|
|
@@ -36,13 +30,13 @@ | |
| }; | ||
|
|
||
| Query.prototype.cloner = function () { | ||
| return this.elements.length ? this.elements[0].cloneNode(true) : null; | ||
| }; | ||
|
|
||
| Query.prototype.text = function (value) { | ||
| // getter | ||
| if (typeof value === 'undefined') { | ||
| return this.elements.length ? this.elements[0].textContent : null; | ||
| } | ||
| //setter | ||
| else { | ||
|
|
@@ -55,7 +49,7 @@ | |
| Query.prototype.val = function (value) { | ||
| // getter | ||
| if (typeof value === 'undefined' && this.elements.length > 0) { | ||
| return this.elements.length ? this.elements[0].value : null; | ||
| } | ||
| //setter | ||
| else { | ||
|
|
@@ -146,19 +140,11 @@ | |
| }; | ||
|
|
||
| Query.prototype.height = function () { | ||
| return this.elements.length ? this.elements[0].offsetHeight : null; | ||
| }; | ||
|
|
||
| Query.prototype.top = function () { | ||
| return this.elements.length ? this.elements[0].offsetTop : null; | ||
| }; | ||
|
|
||
| Query.prototype.listen = function (eventType, callback) { | ||
|
|
@@ -168,7 +154,7 @@ | |
| }; | ||
|
|
||
| Query.prototype.tagName = function () { | ||
| return this.elements.length ? this.elements[0].tagName : null; | ||
| }; | ||
|
|
||
| Query.prototype.addClass = function (classNames) { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this code know about Cypress? It seems like whatever the need is here should be offloaded to the test logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is kinda gross, the problem is though that the data isn't available in the test db, so this warning code will always trigger, even though the actual http requests are stubbed.
Putting this logic here allows Cypress to skip the warning code (which we want) and, in normal use of the app, allows the warning conditional to trigger when we need it.
I think maybe the best solution would be rearchitecting how the warning logic works/how the warning is propagated from the backend to the frontend, but that seemed out of scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd be happy to fast-follow that because this is pretty gross. 😁