Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the include format module instead of the format-usd package. #7998

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

wpears
Copy link
Member

@wpears wpears commented Oct 24, 2023

In #7400 we added format-usd and unformat-usd to modules. There was a note in that PR that perhaps we should have a general utils repo/package in the future.. and that time is now!

This PR, though is just moving old references/uses of format-usd/unformat-usd to the new module so that, when we do the refactor, it will be the same type of changes everywhere.

@wpears wpears requested a review from mistergone October 24, 2023 18:14
Copy link
Member

@mistergone mistergone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I contributed a bunch to format-usd but I nonetheless approve of these changes. 😉

@wpears wpears added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 00e8fbb Oct 31, 2023
8 of 9 checks passed
@wpears wpears deleted the remove-format-usd-ref branch October 31, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants