Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Wagtail from version 4.1 to version 4.2.4 #7926

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Conversation

chosak
Copy link
Member

@chosak chosak commented Aug 17, 2023

This PR upgrades the website from Wagtail 4.1 to Wagtail 4.2.4.

See internal D&CP#387 for details and additional context.

Release notes:

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

@chosak chosak force-pushed the upgrade/wagtail-4.2 branch from d0cc502 to 3489451 Compare August 18, 2023 18:01
@anselmbradford
Copy link
Member

This'll fix the snyk failure currently happening on PRs because of Pillow

@chosak chosak force-pushed the upgrade/wagtail-4.2 branch from 6fc2ac6 to 3d996a3 Compare November 28, 2023 20:44
@chosak chosak marked this pull request as ready for review November 28, 2023 21:01
@chosak chosak added the hold label Nov 28, 2023
Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@chosak chosak force-pushed the upgrade/wagtail-4.2 branch 2 times, most recently from 7040787 to c7a0b39 Compare November 29, 2023 21:17
@chosak chosak removed the hold label Nov 29, 2023
willbarton and others added 13 commits November 29, 2023 17:05
This commit fixes some deprecation warnings that appear when you run
the Python tests against the upgrade/wagtail-4.2 branch. It also
updates some references in the documentation.
Instead of documenting our own custom data migration utilities, point
instead to Wagtail's own documentation:

https://docs.wagtail.org/en/stable/advanced_topics/streamfield_migrations.html#streamfield-data-migrations
We have a TODO comment in the code about something that can be removed
in Wagtail 4.2, but it turns out that we can't actually remove this
setting. If we want to maintain the easy (meaning: we don't need to
worry about running a search index update job) substring search matching
behavior in Wagtail admin search, we need to keep this setting even on
Wagtail 4.2.

Instead of removing, I've instead clarified the comment.
The Wagtail 4.2 release made changes to how the StreamField block UI
is rendered, which broke our table-related Cypress tests that relied on
a particular DOM structure.

This commit fixes those tests. To verify, run a local server and run:

`yarn cypress run --spec=test/cypress/integration/admin/admin.cy.js`
@chosak chosak force-pushed the upgrade/wagtail-4.2 branch from c7a0b39 to 0b03cca Compare November 29, 2023 22:06
@chosak chosak added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit ce329f3 Nov 30, 2023
14 checks passed
@chosak chosak deleted the upgrade/wagtail-4.2 branch November 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants