-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Wagtail from version 4.1 to version 4.2.4 #7926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
force-pushed
the
upgrade/wagtail-4.2
branch
from
August 18, 2023 18:01
d0cc502
to
3489451
Compare
This'll fix the snyk failure currently happening on PRs because of Pillow |
willbarton
force-pushed
the
upgrade/wagtail-4.2
branch
from
November 1, 2023 14:26
053a4b4
to
7e6f66e
Compare
chosak
force-pushed
the
upgrade/wagtail-4.2
branch
from
November 28, 2023 20:44
6fc2ac6
to
3d996a3
Compare
willbarton
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chosak
force-pushed
the
upgrade/wagtail-4.2
branch
2 times, most recently
from
November 29, 2023 21:17
7040787
to
c7a0b39
Compare
Required for Wagtail 4.2 based on: https://docs.wagtail.org/en/stable/releases/4.2.html#wagtail-specific-image-field-wagtailimagefield
This commit fixes some deprecation warnings that appear when you run the Python tests against the upgrade/wagtail-4.2 branch. It also updates some references in the documentation.
Instead of documenting our own custom data migration utilities, point instead to Wagtail's own documentation: https://docs.wagtail.org/en/stable/advanced_topics/streamfield_migrations.html#streamfield-data-migrations
We have a TODO comment in the code about something that can be removed in Wagtail 4.2, but it turns out that we can't actually remove this setting. If we want to maintain the easy (meaning: we don't need to worry about running a search index update job) substring search matching behavior in Wagtail admin search, we need to keep this setting even on Wagtail 4.2. Instead of removing, I've instead clarified the comment.
The Wagtail 4.2 release made changes to how the StreamField block UI is rendered, which broke our table-related Cypress tests that relied on a particular DOM structure. This commit fixes those tests. To verify, run a local server and run: `yarn cypress run --spec=test/cypress/integration/admin/admin.cy.js`
chosak
force-pushed
the
upgrade/wagtail-4.2
branch
from
November 29, 2023 22:06
c7a0b39
to
0b03cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the website from Wagtail 4.1 to Wagtail 4.2.4.
See internal D&CP#387 for details and additional context.
Release notes:
Checklist