different warning check

cfpb · Nov 7, 2023 · b43051f · b43051f
1 parent 3eb9cdd
commit b43051f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cfgov/unprocessed/apps/paying-for-college/js/disclosures/dispatchers/get-api-values.js b/cfgov/unprocessed/apps/paying-for-college/js/disclosures/dispatchers/get-api-values.js
@@ -89,8 +89,9 @@ const getApiValues = {
     const warning = document
       .querySelector('[data-warning]')
       .getAttribute('data-warning');
-    if (warning !== '' && typeof warning !== 'undefined') {
+    if (warning) {
       financialView.missingData(warning);
+      return Promise.resolve();
     }
     return Promise.all([
       this.constants().then((v) => v.json()),

diff --git a/cfgov/unprocessed/apps/paying-for-college/js/disclosures/index.js b/cfgov/unprocessed/apps/paying-for-college/js/disclosures/index.js
@@ -39,6 +39,7 @@ const app = {
   urlValues: {},
   init: function () {
     getApiValues.initialData().then((resp) => {
+      if (!resp) return;
       const [constants, expenses] = resp;
       financialModel.init(constants[0]);
       financialView.init();