Skip to content

Commit

Permalink
always return promise
Browse files Browse the repository at this point in the history
  • Loading branch information
wpears committed Nov 7, 2023
1 parent 817ac56 commit 1e3a333
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ const getApiValues = {
const warning = document
.querySelector('[data-warning]')
.getAttribute('data-warning');
if (warning !== '' && typeof warning !== 'undefined') {
console.log('pre-warning', warning);

Check warning on line 92 in cfgov/unprocessed/apps/paying-for-college/js/disclosures/dispatchers/get-api-values.js

View workflow job for this annotation

GitHub Actions / frontend

Unexpected console statement
/*if (warning !== '' && typeof warning !== 'undefined') {
console.log('warning exists', warning);
financialView.missingData(warning);
const deferred = {};
Expand All @@ -98,7 +99,7 @@ const getApiValues = {
deferred.reject = reject;
});
return deferred;
}
}*/
return Promise.all([
this.constants().then((v) => v.json()),
this.expenses().then((v) => v.json()),
Expand Down

0 comments on commit 1e3a333

Please sign in to comment.