Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
anselmbradford committed Oct 20, 2017
1 parent a641c87 commit bd54243
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
12 changes: 6 additions & 6 deletions src/cf-expandables/src/Expandable.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
'use strict';

const domClassList = require( 'cf-atomic-component/src/utilities/dom-class-list' );
const contains = domClassList.contains;
const addClass = domClassList.addClass;
const closest = require( 'cf-atomic-component/src/utilities/dom-closest' ).closest;
const contains = domClassList.contains;
const removeClass = domClassList.removeClass;
const closest = require( 'cf-atomic-component/src/utilities/dom-closest' ).closest;
const ExpandableTransition = require( 'cf-atomic-component/src/utilities/transition/ExpandableTransition' );
const Events = require( 'cf-atomic-component/src/mixins/Events.js' );
const Organism = require( 'cf-atomic-component/src/components/Organism' );
Expand All @@ -32,12 +32,12 @@ const Expandable = Organism.extend( {
'click .o-expandable-group__accordion .o-expandable_target': 'onToggleAccordion'
},

transition: null,
accordionEvent: null,
transition: null,
accordionEvent: null,
activeAccordion: false,

initialize: initialize,
accordionClose: accordionClose,
initialize: initialize,
accordionClose: accordionClose,
onExpandableClick: onExpandableClick,
onToggleAccordion: onToggleAccordion,
toggleTargetState: toggleTargetState
Expand Down
4 changes: 3 additions & 1 deletion src/cf-tables/src/TableRowLinks.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ function onRowLinkClick( event ) {
}
target = closest( event.target, 'tr' );
const link = target.querySelector( 'a' );
if ( link ) window.location = link.getAttribute( 'href' );
if ( link ) {
window.location = link.getAttribute( 'href' );
}
}

module.exports = TableRowLinks;

0 comments on commit bd54243

Please sign in to comment.