Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add int64 type conversion to sourdump encode and decode #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitmpr
Copy link
Contributor

@gitmpr gitmpr commented Nov 24, 2024

fixes the sourdump go build for me using go version go1.23.2 linux/amd64 which might be more strict on requiring explicit int64 types than go version go1.23.3 linux/amd64 that is used in CI to build sourdump

/sour/assets](main)$ bash -x setup
+++ dirname setup
++ cd .
++ pwd
+ SCRIPT_DIR=/home/mpr/git/sourfork/sour/assets
+ cd /home/mpr/git/sourfork/sour/assets
+ set -e
+ mkdir -p cache
+ pip3 list
+ grep cbor2
+ '[' -f sourdump ']'
+ cd ..
+ go build -o assets/sourdump cmd/sourdump/main.go
# github.com/cfoust/sour/pkg/maps
pkg/maps/decode.go:22:47: cannot use i (variable of type int) as int64 value in argument to worldio.CubeArray_getitem
pkg/maps/decode.go:31:68: cannot use j (variable of type int) as int64 value in argument to worldio.SurfaceInfoArray_getitem
pkg/maps/decode.go:41:59: cannot use j (variable of type int) as int64 value in argument to worldio.UcharArray_getitem
pkg/maps/decode.go:47:62: cannot use j (variable of type int) as int64 value in argument to worldio.Uint16Array_getitem
pkg/maps/encode.go:57:37: cannot use i (variable of type int) as int64 value in argument to worldio.CubeArray_setitem```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant