Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The align_it and align_it_aa methods now belong to the module "Gotoh". #2

Merged
merged 31 commits into from
Nov 22, 2024

Conversation

rhliang
Copy link

@rhliang rhliang commented Oct 24, 2024

No description provided.

@rhliang rhliang self-assigned this Oct 25, 2024
@rhliang rhliang requested a review from va7eex October 25, 2024 23:20
@va7eex
Copy link
Contributor

va7eex commented Oct 25, 2024

I think the content of this pull request is good, but there are some outstanding questions I have that we can discuss in person on Monday.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

rhliang added 2 commits November 20, 2024 15:13
These tests were not run on my workstation; they're also an experiment
to see whether CI is working.
This time the tests *were* run on my workstation; the previous commit
showed that the CI pipeline was working correctly.
Copy link
Contributor

@va7eex va7eex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some variable names we use in our internal gitlab server, please check these are valid github variable names.

ruby/test/templates/index.html.erb Outdated Show resolved Hide resolved
ruby/test/test_helper.rb Outdated Show resolved Hide resolved
@va7eex va7eex merged commit d435a50 into main Nov 22, 2024
3 checks passed
@va7eex va7eex deleted the PutMethodsInModule branch November 22, 2024 19:13
@rhliang rhliang added this to the 0.4.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants