Logarithm axes in plots library #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrswift
commented
Jul 26, 2024
| @@ -303,6 +303,9 @@ | |||
| axis.min -= 1; axis.max += 1 | |||
| } | |||
|
|
|||
| axis.mode = get-axis-option(name, "mode", "lin") | |||
| axis.base = get-axis-option(name, "base", 10) | |||
There was a problem hiding this comment.
I imagine this could be useful for other things, like the ticks PR you have at the moment #18
There was a problem hiding this comment.
If we merge #18, you could pick the default formatter based on the axis options 👍.
The formatter itself does not know about the axis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a continuation of changes discussed in #3, #15)
As with previously, this is a draft PR, intended to share progress and collaborate on what is a highly sought-after feature.
This implementation adds axis optios {x}-mode that takes "lin" (default) or "log", which changes logic in
transform-vec(along with a small refactor). Additionally, a differentcompute-ticksheuristic is defined and applied, which now places major ticks on powers ofaxis.base(default:10), and placesnlogarithmically scaled minor ticks wherenisint(axis.base / ticks.minor-step).