This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 228
Support Enable/Disable NiFi Zookeeper client Zookeeper Ensemble Tracker #294
Closed
nathluu
wants to merge
19
commits into
cetic:master
from
nathluu:nathluu/zkclient-ensemble-tracker-disable
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
253ad43
Disable zkClientEnsembleTracker
nathluu 9bf4698
Update s2s bravo flow.xml
nathluu 2a58c3d
Update s2s test to use cmctl from cert-manager instead of jetstack
nathluu f6a84e7
Change cert-manager installation
nathluu 9d34bed
Fix s2s test (#
nathluu eaed349
Update s2s test
nathluu 944db6d
Add session affinity FAQ (#299)
cf250024 f296a8e
feature/en289 Add a one-volume option for persistence using subPath (…
emrge-michaeld 09dac85
Add auth.oidc.preferredJwsalgorithm param (#306)
happy-code-com f851d51
Add bootstrap options (#308)
combineads 219b17e
relaunch tests
banzo 3519298
Disable zkClientEnsembleTracker
nathluu 020c282
Update s2s bravo flow.xml
nathluu 09953ac
Update s2s test to use cmctl from cert-manager instead of jetstack
nathluu a3f7f5f
Change cert-manager installation
nathluu c003de2
Fix s2s test (#
nathluu 317862a
Update s2s test
nathluu ea0c9e3
relaunch tests
banzo c0d0fb0
Merge branch 'nathluu/zkclient-ensemble-tracker-disable' of github.co…
nathluu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| - name: Setup Minikube | ||
| uses: manusa/[email protected] | ||
| with: | ||
| minikube version: 'v1.30.1' | ||
| minikube version: 'v1.28.0' | ||
| kubernetes version: 'v1.25.4' | ||
| github token: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Checkout code | ||
|
|
@@ -87,12 +87,15 @@ jobs: | |
| - name: Confirm certificate rotation | ||
| run: | | ||
| OLDCERTSTART=$(kubectl -n alpha exec nifi-0 -c server -- curl -kv https://localhost:8443 2>&1 | /bin/grep start) | ||
| echo Certificate "$OLDCERTSTART" | ||
| echo Old Certificate "$OLDCERTSTART" | ||
| cmctl -n alpha renew nifi-0 | ||
| kubectl -n alpha rollout restart statefulset/nifi | ||
| kubectl -n alpha rollout status --watch statefulset/nifi --timeout=5m | ||
| sleep 5m | ||
| for n in [ 0 1 2 3 4 5 6 7 8 9 ] | ||
| do | ||
| NEWCERTSTART=$(kubectl -n alpha exec nifi-0 -c server -- curl -kv https://localhost:8443 2>&1 | /bin/grep start) | ||
| echo Certificate "$NEWCERTSTART" | ||
| echo New Certificate "$NEWCERTSTART" | ||
| if [ \""$OLDCERTSTART"\" != \""$NEWCERTSTART"\" ] | ||
| then | ||
| exit 0 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This defeats the purpose of the test, which was to confirm that NiFi is automatically detecting the certificate has changed and restarting the TLS modules. If we want to disable this test because NiFi is broken, then I would recommend commenting it out with a comment rather than forcing a restart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a TODO to remove this block of code when NIFI issue is fixed