This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Documentation/binderhub #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into documentation/binderhub
alexnuttinck
suggested changes
Mar 25, 2020
There was a problem hiding this comment.
Hello @Sellto, See my different comments before we merge, thanks!
| @@ -0,0 +1,38 @@ | |||
| --- | |||
There was a problem hiding this comment.
Maybe point to these files directly : https://github.com/cetic/fadi/tree/master/helm/traefik ? We don't need to duplicate them.
There was a problem hiding this comment.
Delete this part from the binderhub example
examples/binderhub/README.md
Outdated
|
|
||
| We assume that you have already a cluster deployed. If not, you can refer and follow our [Installation guide]() until the point 1.2.2 | ||
|
|
||
| you will also need to have a valid Docker account. |
examples/binderhub/README.md
Outdated
| cd $pwd/fadi/examples/binderhub | ||
| ``` | ||
|
|
||
| 2. open the **config.yaml** file to set your docker credentials and the the name of your project to the following inputs: |
There was a problem hiding this comment.
Not clear what to set for the image_prefix
There was a problem hiding this comment.
Added a little explanation...
| config: | ||
| BinderHub: | ||
| use_registry: true | ||
| image_prefix: <DOCKER_ID>/<PROJECT_NAME>- |
There was a problem hiding this comment.
Please explain what is Docker ID, Project Name
There was a problem hiding this comment.
added a remarks to explain the construction of a image prefix
|
I think I have considered all the remarks |
added 4 commits
May 17, 2020 13:20
banzo
approved these changes
May 17, 2020
banzo
added a commit
that referenced
this pull request
Nov 15, 2021
* Feature/zabbix (#110) * Documentation links fix (#95) * fix the password to connect to Adminer (#99) * Update logging doc (#103) * fix #105 (#115) * Feature/rancher proxmox (#117) * Documentation/binderhub (#112) * group management (#113) * Feature/tests (#123) - Setup the testing framework for fadi. Add automated testing of the services using Jest and Puppeteer, test cases and scenarios specifications and implementation. * Usermanagement documentation (Nifi) + Tensorflow use case (#130) * NiFi - LDAP Documentation * Feature/seldon - ML models management (#122) * Add new flag to helm repo add to overwrite the cetic chart repo if already present (#133) * Add zakaria2905 to contributors * Userguide update (#135) * Monitoring and various documentation fixes (#111) * Update INSTALL.md * CI/CD with minikube * ldap documentation * elastic-stack ldap documentation * Details on JHub LDAP documentation * Helm 3 - Remove deprecated tiller ref, updated traefik install version * Feature/zabbix (#110) * Documentation links fix (#95) * fix the password to connect to Adminer (#99) * Update logging doc (#103) * Zabbix doc: cetic/helm-fadi#27 * fix #105 (#115) * fix #121 Co-authored-by: Sebastien Dupont <[email protected]> Co-authored-by: Amen Ayadi <[email protected]> Co-authored-by: Alexandre Nuttinck <[email protected]> Co-authored-by: Faiez Zalila <[email protected]> Co-authored-by: Sellto <[email protected]> Co-authored-by: Faiez Zalila <[email protected]> Co-authored-by: Rami Sellami <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Status : Done
-> Just need a review of the README.md