Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Feat/age dependent links #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat/age dependent links #68

wants to merge 3 commits into from

Conversation

mvdegtyar
Copy link
Collaborator

As discussed on weekly added 3 buttons with links yo:

  • kindergartens
  • high schools
  • universities
    Need to clarify if kindergarten button should be displaced for all kids with before school age or just for kids younger than 3.

@vercel
Copy link

vercel bot commented Aug 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mistoveskole ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 4:23PM (UTC)

@quentincaffeino
Copy link
Contributor

This project uses yarn instead of npm, please remove package-lock.json from your second commit

@stefanides
Copy link
Collaborator

@mvdegtyar is the feature already visible? I do not see any change for 1-2 or 17+ years

kindergarten is for 3,4,5, years, now should be also one of two buttons for 2 years

@mvdegtyar
Copy link
Collaborator Author

mvdegtyar commented Aug 26, 2022

as for

is the feature already visible? I do not see any change for 1-2 or 17+ years

My bad, missed one file in commit, now it's fixed.
image
so text on button changes and now instead of navigating to map it opens anew browser tab

image
for 3 and 4 year of high school there are 2 buttons: list of high school and list of universities

image
for kids before 2 years - there is button to open kindergartens

Please let me know if it works for you and if is it a correct behavior for this feature

@mvdegtyar
Copy link
Collaborator Author

mvdegtyar commented Aug 26, 2022

This project uses yarn instead of npm, please remove package-lock.json from your second commit

fixed

@stefanides
Copy link
Collaborator

@mvdegtyar thanks, now it works. just

  • 2003 to 2007 hide the inactive button
  • 2003 to 2005 add one more text placeholder between active buttons to explain why there are two
  • 2021 hide inactive button
  • 2020 add one more text between buttons, make first button active and link it to the same map as 2019 (and the first text will need to be extented with the explanation)

@quentincaffeino
Copy link
Contributor

  • 2003 to 2007 hide the inactive button
  • 2021 hide inactive button

Layout shifts are undesirable in ux, was it agreed on during weekly standup?

@mvdegtyar
Copy link
Collaborator Author

Layout shifts are undesirable in ux, was it agreed on during weekly standup?

UX designer is not available now, so it was decided to make some working version, which could be improved later.

@stefanides
Copy link
Collaborator

  • 2003 to 2007 hide the inactive button
  • 2021 hide inactive button

Layout shifts are undesirable in ux, was it agreed on during weekly standup?

anyway there are shifts due to the extra text being displayed. And in this case the first button should get replaced - it will make no shift. if there is a better solution how to show second button+text without a shift I do not know.. ie. put there empty space which will be used only in some scenarios?

@klarasch
Copy link
Collaborator

Great job <3 I like how you agile-style you fixed this guys! From UX perspective, I would only replace the usual "Display schools..." button with the new one – I wouldn't show it disabled. Some short copy and explanation that we don't do this here but will forward to a different site would be nice, but perhaps redundant and confusing, so not showing two buttons at once and only the working one will do it :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants