Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong date bug in schedule page #230

Closed
wants to merge 4 commits into from
Closed

Conversation

diogogmatos
Copy link
Member

No description provided.

@diogogmatos diogogmatos added the bug Something isn't working label Sep 13, 2024
@diogogmatos diogogmatos self-assigned this Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for cesium-calendarium ready!

Name Link
🔨 Latest commit e426359
🔍 Latest deploy log https://app.netlify.com/sites/cesium-calendarium/deploys/66ec96ead3476f000837fb5a
😎 Deploy Preview https://deploy-preview-230--cesium-calendarium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diogogmatos
Copy link
Member Author

I guess we will only know if this worked tomorrow 🫠

ruilopesm
ruilopesm previously approved these changes Sep 13, 2024
@diogogmatos
Copy link
Member Author

diogogmatos commented Sep 13, 2024

@ruilopesm not sure this works yet, because the deploy preview was built today and the bug only happens when the deployed version was built on a different day than the current date. The highlighted day in the schedule page is the day when the app was built. For example, right now Calendarium is highlighting Thursday as the current day even though it is Friday, because the last deploy of the site was yesterday.

@ruilopesm
Copy link
Member

@diogogmatos Let's wait till tomorrow, then 😁

@ruilopesm
Copy link
Member

@diogogmatos I just checked calendarium on production and for me, on my mobile, it's correct (highlighting friday). Don't know if this is happening to just some people. In fact, yesterday it was happening on my computer 😅

@diogogmatos
Copy link
Member Author

@diogogmatos I just checked calendarium on production and for me, on my mobile, it's correct (highlighting friday). Don't know if this is happening to just some people. In fact, yesterday it was happening on my computer 😅

@ruilopesm it only happens when you open the page directly in /schedule or refresh the page while in /schedule. If you open in / and then change to /schedule it works correctly. (I know very weird)

@ruilopesm
Copy link
Member

@diogogmatos I can reproduce it now. What a strange bug 💀

@joaodiaslobo
Copy link
Member

joaodiaslobo commented Sep 13, 2024

@diogogmatos @ruilopesm Unfortunately, I don't think this fixed the bug. 🥲
We have a very odd one on our hands :shipit:

@diogogmatos
Copy link
Member Author

Fixed for now in #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants