Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Themes #125

Merged
merged 16 commits into from
Sep 1, 2023
Merged

Add Color Themes #125

merged 16 commits into from
Sep 1, 2023

Conversation

diogogmatos
Copy link
Member

@diogogmatos diogogmatos commented Aug 25, 2023

Added support for color themes across all the pages, including the ability to create a custom theme.

To achieve this:

  • Created a new Settings page that can in the future hold other configurations besides themes, like push-notifications, etc.
  • Made several changes and adjustments to the way the event colors are applied.
  • Used the local storage to save all settings (themes) and as a way to communicate to index.tsx and schedule.tsx the current theming configuration.
  • Changed the way the Schedule events are colored, as they now follow whatever colors are set for the events in the Events page. A subject that has a red color in Events will also have a red color in Schedule, and so on. By default, the events are themed by Year (as to distinguish between different years), which means the events in the Schedule page will also be themed by year. Basically, all the coloring is 100% synchronized between the two pages, as to achieve a common theme across the platform.
  • A lot of other stuff I don't even remember anymore, I'm open to questions kk.

Additional Improvements:

  • Transitioned even more code to Tailwindcss, including the Export and Clear Schedule buttons.
  • Added the "Check Indicators" to every Collapse of the filters. There's no easy way to explain this by text, but I basically made it so the tiny blue ball that indicated if you had checkboxes selected inside that collapse will now appear in every collapse, not just the ones immediately before the checkbox. This means that if you have the T1 shift of BD selected, the "2nd year" collapse will have a little indicator that something inside is selected, as well as the "2nd semester" collapse, as well as the "BD" collapse.
  • Probably other not visible things.

Note: This is a huge PR so I would appreciate it if you guys tested the hell out of it for bugs because there is a very high chance of those existing, despite all the ones I've already fixed.

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for cesium-calendarium ready!

Name Link
🔨 Latest commit c59c024
🔍 Latest deploy log https://app.netlify.com/sites/cesium-calendarium/deploys/64f0b53748bda40008461f1e
😎 Deploy Preview https://deploy-preview-125--cesium-calendarium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diogogmatos diogogmatos self-assigned this Aug 25, 2023
@diogogmatos diogogmatos added the enhancement New feature or request label Aug 25, 2023
@diogogmatos diogogmatos marked this pull request as ready for review August 26, 2023 18:26
@ruilopesm
Copy link
Member

What about adding a reference of this new feature to the README's "Features" section?

@diogogmatos
Copy link
Member Author

What about adding a reference of this new feature to the README's "Features" section?

Done @RuiL1904 ;)

Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind this comment 😅

@diogogmatos diogogmatos merged commit 36fbbec into master Sep 1, 2023
5 checks passed
@diogogmatos diogogmatos deleted the dm/themes branch September 1, 2023 09:28
@diogogmatos diogogmatos mentioned this pull request Oct 9, 2023
diogogmatos added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants