Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification plugin #159

Merged
merged 66 commits into from
Feb 13, 2017
Merged

Conversation

gcrahay
Copy link
Contributor

@gcrahay gcrahay commented Jan 16, 2017

As proposed in #158, this PR adds a plugin sending notifications. Notification event included are:

  • Event created
  • Event updated
  • Incident created
  • Incident updated
  • Event commented
  • Incident commented
  • Event status changed
  • Incident status changed

Users can subscribe to these events in their preference panel.

See the included Readme file for more details.

@gcrahay
Copy link
Contributor Author

gcrahay commented Jan 26, 2017

Based on @gaelmuller review:

  • Move email logic to fir_email
  • Move S/MIME stuff to fir_email
  • Refactor subscription UI
  • Fix fir_notifications requirement (xmpppy)
  • Move EXTERNAL_URL setting to production.py.sample
  • Do not require a running XMPP server on FIR start

@PaulSec
Copy link

PaulSec commented Feb 7, 2017

That looks nice, any update on the integration by any chance?

@gaelmuller gaelmuller merged commit b16e68d into certsocietegenerale:master Feb 13, 2017
@gaelmuller
Copy link
Contributor

Looks great, thank you !

@PaulSec
Copy link

PaulSec commented Feb 13, 2017

Nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants