-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update route53.md #790
base: master
Are you sure you want to change the base?
Update route53.md #790
Conversation
The route53:ListHostedZones action is also required for acme to renew the certs
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @atif1996. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atif1996 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: ff161b3 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61d0aeea3700db0007aa0128 😎 Browse the preview: https://deploy-preview-790--cert-manager-website.netlify.app |
"Action": [ | ||
"route53:ListHostedZonesByName", | ||
"route53:ListHostedZones" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about AWS permissions to know whether this is safe.
I see others have mentioned this permission in cert-manager issues:
But I'm not sure we need both ListHostedZonesByName
and ListHostedZones
.
Please explain why ListHostedZonesByName
is insufficient and update the Note:
below.
@atif1996: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@atif1996 can you please sign your commits? (see https://cert-manager.io/docs/contributing/sign-off/) |
The route53:ListHostedZones action is also required for acme to renew the certs