Improve test case

[cmoulliard]

• Ignore idea and _out directory
• Add missing dot end of the DNS name
• Update dependencies. To be controlled
• Uncomment email and ApiSecretRef
• Add script to fetch kubebuilder binaries
• Add DNS server. Set additional vars

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cmoulliard
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cmoulliard]

/assign @munnerz

[cmoulliard]

FYI. The link to the CONTRIBUTING guide is missing @munnerz -> https://github.com/jetstack/cert-manager-webhook-example/blob/master/CONTRIBUTING.md

[jetstack-bot]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• 7621c67 Remove non used vars. Add setUseAuthoritative(false) to avoid the error : suite.go:49: error waiting for DNS record propagation: Could not determine authoritative nameservers for cert-manager-dns01-tests.example.com.
• 7415d9a Added local DNS server. Signed-off-by: Charles Moulliard [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cmoulliard]

@munnerz Can you have a look to this ticket ?

[munnerz]

Thanks for putting this together and sorry for the delay 😬

I've added a few comments - mostly I think we should keep the example fairly generic and not start talking about the RFC2136 issuer here, as it could cause confusion for users getting started writing their own webhook.

[munnerz]

Not all of these fields are required by all DNS provider types, hence keeping the contents here generic. Can you revert these changes, and if you feel there could be additional clarification as to what a user should do here then add comments to explain it?

[cmoulliard]

I don't think that I included them or maybe this is because they were defined within one of the example of the cert manager project. So, do you suggest that we remove the fields Email and APIKeySecretRef ?

[munnerz]

Referencing the RFC2136 solver here is confusing to users, and also won't result in the RFC2136 issuer actually being used (as dns.NewFixture(&customDNSProviderSolver{} is still called).

Having the binaries path set + the script to fetch those binaries is great, but I think this example should be generic and show a basic setup that needs a bit of modification or commenting/uncommenting of example lines to get things to work.

[cmoulliard]

So, what do you suggest that we do then here ?

[jetstack-bot]

@cmoulliard: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.