This repository has been archived by the owner on May 7, 2024. It is now read-only.
Review and Updates for Encounter #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoCrespo-ora
requested review from
gmodrogan,
amcginn,
krycunn,
kckeim,
cldeitrich,
summerlcollins and
AlexandruBasarab
Edits per PRODOC-202540
Edits per PRODOC-202540
summerlcollins
approved these changes
Oct 23, 2023
amcginn
reviewed
Oct 26, 2023
amcginn
reviewed
Oct 26, 2023
| * `_revinclude` is provided in a request to the closed endpoint, the OAuth2 token must include the `user/Provenance.read` scope. Currently, `patient/Provenance.read` is not supported and hence `_revinclude` cannot be utilized for patient persona. | ||
| * When using the `_revinclude` parameter: | ||
| * It may be provided once with the value `Provenance:target`. Example: `_revinclude=Provenance:target` | ||
| * It may be provided with the `_id/patient/subject/account` parameter. Example: `_id=74771957,4732066&_revinclude=Provenance:target` |
There was a problem hiding this comment.
let's split these fields to be more clear that they are separate parameters
There was a problem hiding this comment.
Do you mean split like this?
- When using the
_revincludeparameter:- It may be provided once with the value
Provenance:target. Example:_revinclude=Provenance:target - It may be provided with the
_id parameter. Example:_id=74771957,4732066&_revinclude=Provenance:target` - It may be provided with the
patientparameter. Example:example here - It may be provided with the
subjectparameter. Example:example here - It may be provided with the
accountparameter. Example:example here
- It may be provided once with the value
amcginn
reviewed
Oct 26, 2023
amcginn
approved these changes
Oct 26, 2023
amcginn
added
R4
kckeim
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Additional / non-changed lines that need attention:
R4 Markdown:
- Line 20 - should have "Encounter id" changed to "Encounter ID"
- Line 51 - I want to have us change that to just on-page link to the Extensions section instead of naming all the elements and then linking to the below section. Can also drop the
targetinput there- e.g. change to
[Extensions](#extensions)instead of[Extensions including...](#extensions){:target="_blank"}
- e.g. change to
amcginn
reviewed
Oct 26, 2023
kckeim
approved these changes
Oct 27, 2023
napster235
approved these changes
Nov 3, 2023
napster235
approved these changes
Nov 3, 2023
Someshnsn
added a commit
that referenced
this pull request
Nov 10, 2023
* R4 Appointment updates (#988) * Diagnostic report r4 docs migrate (#991) * Updated DiagnosticReport DSTU2 Resource (#992) * Update DSTU 2 Appointment documentation (#993) * R4_UK_BRAM_Update_Slot_include (#994) * Reorder actions to Search, Read, Create, Patch (#995) * Review and Corrections for Condition (#996) * Update action-comment in cancellation workflow and custom encounter search (#997) * Updated DocumentReference R4 Resource (#999) * Review and updates for Location (#1001) * Diagnostic Report Create for Cardiology and Anatomic pathology (#1002) * Review and Updates for Encounter (#1007) * Review and Updates for NutritionOrder (#1008)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for migrating to Oracle docs, we are reviewing and correcting any inconsistencies, typos, broken links, etc. This PR aims to correct any of the above that needs to be addressed within Encounter and any other information directly referenced by it.
Reformatting for Parameters table
Before
After
Re-formatting Revinclude parameter details
Before
After
Revinclude example response header fix
Before
After
Anonymization of x-request for create and patch responses
Before
After
Fixed broken links for Encounter Priority
Before
On clicking Encounter Priority details link
After
PR Checklist