Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ethereum and ipld-eth-db #35

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Update go-ethereum and ipld-eth-db #35

merged 4 commits into from
Aug 23, 2023

Conversation

roysc
Copy link
Collaborator

@roysc roysc commented Aug 10, 2023

- index non-canonical data first in tests
@roysc roysc requested a review from i-norden August 10, 2023 16:24
Copy link
Contributor

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a new release of ipld-eth-server to work?

pkg/validator/validator_test.go Show resolved Hide resolved
@roysc
Copy link
Collaborator Author

roysc commented Aug 10, 2023

Looks like this needs a new release of ipld-eth-server to work?

Doesn't seem to actually. v5.0.0-alpha has calls to canonical_header_hash to identify blocks but the function is still defined, so I haven't seen any issues.

@i-norden
Copy link
Contributor

Looks like this needs a new release of ipld-eth-server to work?

Doesn't seem to actually. v5.0.0-alpha has calls to canonical_header_hash to identify blocks but the function is still defined, so I haven't seen any issues.

Ah I see, we should go ahead and cut a release of ipld-eth-server that includes cerc-io/ipld-eth-server#253 so we aren't dependent on the canonical_header_hash function as the intention is to drop that function once it is no longer in use.

@i-norden
Copy link
Contributor

Plus there are some other changes in https://github.com/cerc-io/ipld-eth-server/releases/tag/v5.0.1-alpha that are perhaps worth capturing here as well

@roysc
Copy link
Collaborator Author

roysc commented Aug 11, 2023

Roger, updated.

@roysc roysc requested a review from i-norden August 11, 2023 06:33
@i-norden i-norden merged commit 911f6f7 into v5 Aug 23, 2023
2 checks passed
@roysc roysc deleted the update-schema branch August 23, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use https://github.com/cerc-io/ipld-eth-db/releases/tag/v5.0.5-alpha schema
2 participants