feat: Use ajv-threads package to parallelize jsonSchema validation of ModelInstanceDocuments #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
force-pushed
the
threadedSchemaValidation
branch
2 times, most recently
from
4288fe2
to
dfc524e
Compare
stbrody
changed the title
stbrody
force-pushed
the
threadedSchemaValidation
branch
from
dfc524e
to
f2b50c6
Compare
dav1do
approved these changes
Mar 5, 2024
This will make schema validation in js-ceramic truly parallel for the first time
stbrody
force-pushed
the
threadedSchemaValidation
branch
from
540319e
to
3a1e0db
Compare
stbrody
changed the title
|
Why havent this been merged? |
We said that we want to see that this will improve performance before merging it. So far our testing has shown this PR having no impact on performance/throughput whatsoever, which is surprising, so we want to understand what's happening first. Personally I'd be fine with merging and then iterating in develop, but I don't feel strongly and I believe @nathanielc prefers to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.