chore(blockchain-utils-validation): Make TS strict

ceramicnetwork · Aug 2, 2023 · 25c5d6c · 25c5d6c
1 parent c4d482f
commit 25c5d6c
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 15 deletions.
diff --git a/packages/blockchain-utils-linking/src/filecoin.ts b/packages/blockchain-utils-linking/src/filecoin.ts
@@ -2,19 +2,7 @@ import { AuthProvider } from './auth-provider.js'
 import { AccountId } from 'caip'
 import { asOldCaipString, getConsentMessage, LinkProof } from './util.js'
 import * as uint8arrays from 'uint8arrays'
-
-type MessageParams = {
-  From: string
-  To: string
-  Value: '0'
-  Method: 0
-  GasPrice: '1'
-  GasLimit: 1000
-  Nonce: 0
-  Params: string
-  GasFeeCap: string
-  GasPremium: string
-}
+import type { MessageParams } from '@zondax/filecoin-signing-tools'
 
 export class FilecoinAuthProvider implements AuthProvider {
   readonly isAuthProvider = true

diff --git a/packages/blockchain-utils-validation/src/blockchains/ethereum.ts b/packages/blockchain-utils-validation/src/blockchains/ethereum.ts
@@ -60,7 +60,7 @@ async function validateErc1271Link(proof: LinkProof): Promise<LinkProof | null>
   const provider = getEthersProvider(account.chainId.reference)
   const contract = new Contract(account.address, ERC1271_ABI, provider)
   const message = utf8toHex(proof.message)
-  const returnValue = await contract.isValidSignature(message, proof.signature)
+  const returnValue = await contract['isValidSignature'](message, proof.signature)
 
   return returnValue === MAGIC_ERC1271_VALUE ? proof : null
 }

diff --git a/packages/blockchain-utils-validation/tsconfig.json b/packages/blockchain-utils-validation/tsconfig.json
@@ -2,7 +2,15 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "outDir": "lib",
-    "rootDir": "src"
+    "rootDir": "src",
+    "strict": true,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUncheckedIndexedAccess": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   },
   "include": [
     "./src/**/*"

diff --git a/types/@smontero__eosio-signing-tools/index.d.ts b/types/@smontero__eosio-signing-tools/index.d.ts
@@ -0,0 +1,12 @@
+declare module '@smontero/eosio-signing-tools' {
+  type VerifySignatureArgs = {
+    chainId: string
+    account: string
+    signature: string
+    data: string
+  }
+
+  export class SigningTools {
+    static verifySignature(args: VerifySignatureArgs): Promise<boolean>
+  }
+}
diff --git a/types/@zondax__filecoin-signing-tools/index.d.ts b/types/@zondax__filecoin-signing-tools/index.d.ts
@@ -0,0 +1,21 @@
+/// <reference types="node" />
+declare module '@zondax/filecoin-signing-tools' {
+  export type MessageParams = {
+    From: string
+    To: string
+    Value: string
+    Method: 0
+    GasPrice: string
+    GasLimit: 1000
+    Nonce: 0
+    Params: string
+    GasFeeCap: string
+    GasPremium: string
+  }
+
+  export function transactionSerialize(message: MessageParams): string
+  export function verifySignature(
+    signature: string | Buffer,
+    message: MessageParams | string
+  ): boolean
+}