s3: test GetObject with PartNumber and SSE-C encryption #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
commented
Sep 27, 2024
| assert response['ContentLength'] == size | ||
| # compare contents | ||
| for chunk in response['Body'].iter_chunks(): | ||
| assert chunk.decode() == data[0:len(chunk)] |
There was a problem hiding this comment.
when this test runs against rgw without the fix from ceph/ceph#60019, it fails here with:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x84 in position 4: invalid start byte
because it's getting the encrypted bytes
14 tasks
Signed-off-by: Casey Bodley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test case for ceph/ceph#60019
copies the existing
test_multipart_get_part()test but replaces_multipart_upload()with_multipart_upload_enc()