Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/logging: basic set of tests for bucket logging #576

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yuvalif
Copy link
Contributor

@yuvalif yuvalif commented Aug 8, 2024

bucket logging is implemented here: ceph/ceph#59808
ceph/ceph#54815

@yuvalif
Copy link
Contributor Author

yuvalif commented Sep 19, 2024

missing test:

  • add versioned bucket tests
  • test conf update
  • test LC on log bucket
  • add a separate test suite to cover "Standard" mode even if we have extensions

yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 11, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 14, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 14, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 20, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
as well as multi-delete tests

Signed-off-by: Yuval Lifshitz <[email protected]>
also verify tests are passing with/without extensions

Signed-off-by: Yuval Lifshitz <[email protected]>
as well as older boto versions with missing field

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 22, 2024

test is passing. see: ceph/ceph#60700 (comment)

@cbodley
Copy link
Contributor

cbodley commented Nov 25, 2024

why is it necessary to duplicate the s3 extensions file from the ceph repo? i'd rather not worry about trying to keep those in sync

@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 25, 2024

why is it necessary to duplicate the s3 extensions file from the ceph repo? i'd rather not worry about trying to keep those in sync

the other (and better) option is to fetch it from the ceph repo, but in my case I had to have a way to fetch it from a branch on my ceph fork.

yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 26, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 26, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 27, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 27, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 27, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants