Don't try to set devices fact when osd_auto_discovery was skipped #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, under certain OS and Ansible versions, ie Rocky Linux and
ansible-core 2.17, `devices_check` variable is getting defined even if
task was skipped.
That results in set_fact to fail, as resulting variable has no `results`
key in it.
Structure of such variable looks like that:
```
"devices_check": {
"changed": false,
"false_condition": "osd_auto_discovery | default(False) | bool",
"skip_reason": "Conditional result was False",
"skipped": true
}
```
Checking for task not being skipped solves such issues.
Signed-off-by: Dmitriy Rabotyagov <[email protected]>
noonedeadpunk
force-pushed
the
devices_check_skipped
branch
from
5ba3b2c to
5d45cf4
Compare
|
Would be very nice if it's possible to backport to |
clwluvw
approved these changes
Oct 28, 2024
|
Thanks a ton for prompt review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, under certain OS and Ansible versions, ie Rocky Linux and
ansible-core 2.17,
devices_checkvariable is getting defined even iftask was skipped.
That results in set_fact to fail, as resulting variable has no
resultskey in it.
Structure of such variable looks like that:
Checking for task not being skipped solves such issues.
Signed-Off-By: Dmitriy Rabotyagov [email protected]