Skip to content

Commit

Permalink
devices: test devices before collecting on auto discovery
Browse files Browse the repository at this point in the history
In some scenarios with NVMe, a device might be identified by
Ansible but could actually be a multipath device rather than an
actual device. We need to exclude these as Ceph cannot create
OSDs on them.

Signed-off-by: Seena Fallah <[email protected]>
(cherry picked from commit be9b458)
  • Loading branch information
clwluvw authored and asm0deuz committed Aug 13, 2024
1 parent f0bcf7f commit 5f85f32
Showing 1 changed file with 17 additions and 4 deletions.
21 changes: 17 additions & 4 deletions roles/ceph-facts/tasks/devices.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,13 @@
ansible.builtin.set_fact:
bluestore_wal_devices: "{{ bluestore_wal_devices_prepare_canonicalize.results | map(attribute='stdout') | reject('search', '/dev/disk') | list | unique }}"

- name: Set_fact devices generate device list when osd_auto_discovery
- name: Collect existed devices
vars:
device: "{{ item.key | regex_replace('^', '/dev/') }}"
ansible.builtin.set_fact:
devices: "{{ devices | default([]) | union([device]) }}"
with_dict: "{{ ansible_facts['devices'] }}"
ansible.builtin.command: test -b {{ device }}
changed_when: false
ignore_errors: true
loop: "{{ ansible_facts['devices'] | dict2items }}"
when:
- osd_auto_discovery | default(False) | bool
- ansible_facts['devices'] is defined
Expand All @@ -65,3 +66,15 @@
- device not in dedicated_devices | default([])
- device not in bluestore_wal_devices | default([])
- device not in (lvm_volumes | default([]) | map(attribute='data') | list)
register: devices_check

- name: Set_fact devices generate device list when osd_auto_discovery
vars:
device: "{{ item.item.key | regex_replace('^', '/dev/') }}"
ansible.builtin.set_fact:
devices: "{{ devices | default([]) | union([device]) }}"
loop: "{{ devices_check.results }}"
when:
- devices_check is defined
- not item.skipped | default(false)
- not item.failed | default(false)

0 comments on commit 5f85f32

Please sign in to comment.